fix(notifications): set destructiveHint false on subscription tools#2845
Open
syf2211 wants to merge 1 commit into
Open
fix(notifications): set destructiveHint false on subscription tools#2845syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Under MCP schema 2025-06-18, an omitted destructiveHint defaults to true. manage_notification_subscription and manage_repository_notification_subscription only update the caller's own subscription preferences, so mark them explicitly non-destructive to avoid over-warning consent UIs. Fixes github#2841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly mark
manage_notification_subscriptionandmanage_repository_notification_subscriptionas non-destructive MCP tools.Why
Fixes #2841
Under MCP schema 2025-06-18, an omitted
destructiveHintdefaults totruewhenreadOnlyHintisfalse. These tools only update the caller's own notification subscription preferences (watch/ignore/delete subscription record) and do not modify thread or repository content, so conformant clients were over-warning on consent UIs.What changed
DestructiveHint: jsonschema.Ptr(false)on both notification subscription tools inpkg/github/notifications.gopkg/github/notifications_test.goMCP impact
destructiveHint: falseinstead of inheriting the schema default oftrue.Prompts tested (tool changes only)
Security / limits
Tool renaming
Lint & tests
./script/lintUPDATE_TOOLSNAPS=true go test ./pkg/github/ -run 'Test_ManageNotificationSubscription|Test_ManageRepositoryNotificationSubscription' -count=1Docs